[Tcl-bugs] [Tcl] (dgp) tkt (Closed): Potential Tcl_Obj leak in tclPathObj.c

Previous Topic Next Topic
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[Tcl-bugs] [Tcl] (dgp) tkt (Closed): Potential Tcl_Obj leak in tclPathObj.c

Automated mail by fx, on behalf of [hidden email]

Ticket Change [d36648d49401f45a3472cb313bf9c4c0eba50a3e]
  [Potential Tcl_Obj leak in tclPathObj.c]
  By      dgp
  For     Tcl
  On      2017-07-06T14:14:56.489
  Details https://core.tcl.tk/tcl/tinfo?name=d36648d49401f45a3472cb313bf9c4c0eba50a3e
  Ticket  https://core.tcl.tk/tcl/tktview/adb198c256df8c4192838cc3c1112fb2821314e9

Changed Fields
  closedate: 2017-07-06 14:14:56
  icomment:  This large conditional block


             is conditioned on (i == 0) among others.

             That means we can only execute this block on  the first iteration of
             the for loop, and at  that point, nothing has had the chance to make
             res contain anything other than NULL. Much  code directing what to do
             when (res != NULL)  is actually useless. Some asserts would be better,
             I think.
  login:     dgp

See Tcl/Tk development @ http://core.tcl.tk/

Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Tcl-Bugs mailing list
[hidden email]