Another file dialog bug on OSX

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Another file dialog bug on OSX

Christian Gollwitzer
Hi all,

on clt Torsten reported a bug in the file dialog box. The problem is a
bit subtle, sometimes the initialdir/initialfile is ignored or
mistreated. It is a consequence of some ineffective fix of the API
change after OSX 10.5. The attached patch fixes the problem.

        Christian

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Tcl-Core mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tcl-core

urlbug.tcl (467 bytes) Download Attachment
0001-Fix-broken-URL-construction-from-file-names.patch (6K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Another file dialog bug on OSX

Kevin Walzer-3
On 6/3/17 5:03 PM, Christian Gollwitzer wrote:
> Hi all,
>
> on clt Torsten reported a bug in the file dialog box. The problem is a
> bit subtle, sometimes the initialdir/initialfile is ignored or
> mistreated. It is a consequence of some ineffective fix of the API
> change after OSX 10.5. The attached patch fixes the problem.
>
>     Christian
Thank you Christian for this patch.

Would you be interested in getting commit rights to Tk's core? I can't
remember who is in charge of such things, but you would certainly have
my support. If you are not interested or do not have time, I will review
this in the coming week.

Thanks,
Kevin

--
Kevin Walzer
Code by Kevin/Mobile Code by Kevin
http://www.codebykevin.com
http://www.wtmobilesoftware.com


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Tcl-Core mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tcl-core
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Another file dialog bug on OSX

Christian Gollwitzer
Hi Kevin,

Am 04.06.17 um 04:14 schrieb Kevin Walzer:
> Thank you Christian for this patch.
>
> Would you be interested in getting commit rights to Tk's core? I can't
> remember who is in charge of such things, but you would certainly have
> my support. If you are not interested or do not have time, I will review
> this in the coming week.

I'm shying away from the responsibility ;) it's too easy to mess things
up with direct write access. I'd much prefer a pull-request style
workflow, that's why I'm sending patches. So please check that the issue
is fixed with the patch and commit it on my behalf, if satisified.

As mentioned last time, this code has many duplicated parts and is
entangled with #ifdefs for different OSX versions, which makes it hard
to test and understand. I'm not really willing to clean this mess up
rigt now, maybe some time later it would be useful to refactor it.

        Christian

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Tcl-Core mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tcl-core
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Another file dialog bug on OSX

Francois Vogel
In reply to this post by Christian Gollwitzer
> I'm shying away from the responsibility ;) it's too easy to mess things
> up with direct write access. I'd much prefer a pull-request style
> workflow, that's why I'm sending patches

Well, this is version control. Anything can easily be reverted.

If you commit in a bugfix branch specifically created for this bug and ask for review, that will already be something less to do for the (very low number of) maintainers. If you're shy about merging to core-8-6-branch or trunk, then just don't and ask someone else to do it instead, who will then necessarily review because of taking responsibility for merging.

In the recent past I have granted commit access to several people. Nothing bad happened... and I had much less to do to make things happen, which is the goal!

Please dare! Especially you, who is a long time respected member of the Tcl/Tk community and know the project very very well.

Fran├žois.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Tcl-Core mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tcl-core
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Another file dialog bug on OSX

Donal K. Fellows-2
On 04/06/2017 11:08, Francois Vogel wrote:
> If you commit in a bugfix branch specifically created for this bug and
> ask for review, that will already be something less to do for the (very
> low number of) maintainers.

This is the recommended approach. Alternatively, and less preferably,
attach the patch to an issue. At least then it won't get lost since we
replicate the issues widely along with the rest of the fossil repo.

Donal.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Tcl-Core mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tcl-core

donal_k_fellows.vcf (241 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Another file dialog bug on OSX

Christian Gollwitzer
Am 04.06.17 um 16:01 schrieb Donal K. Fellows:
> On 04/06/2017 11:08, Francois Vogel wrote:
>> If you commit in a bugfix branch specifically created for this bug and
>> ask for review, that will already be something less to do for the (very
>> low number of) maintainers.
>
> This is the recommended approach. Alternatively, and less preferably,
> attach the patch to an issue.

That's what I did:

http://core.tcl.tk/tk/tktview?name=9eab541213

        Christian


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Tcl-Core mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tcl-core
Loading...